<p><b>@frlan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/378#pullrequestreview-15014760">lineoperations/src/linefunctions.c</a>:</p>
<pre style='color:#555'>>  
        /* loop through **lines, join first occurances into one str (new_file) */
-       for(i = 0; i < total_num_lines; i++)
+       for(i = 0; i < num_lines; i++)
</pre>
<p>You should check earlier, whether num_lines is > 0</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/378#pullrequestreview-15014760">lineoperations/src/linefunctions.c</a>:</p>
<pre style='color:#555'>>  
        /* allocate and set *to_remove to all FALSE
         * to_remove[i] represents whether lines[i] should be removed  */
-       to_remove = g_malloc(sizeof(gboolean) * total_num_lines);
-       for(i = 0; i < (total_num_lines); i++)
+       to_remove = g_malloc(sizeof(gboolean) * num_lines);
+       for(i = 0; i < (num_lines); i++)
</pre>
<p>Same as before: You should check whether num_lines > 0  even you might only call it from your code</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/378#pullrequestreview-15014760">lineoperations/src/linefunctions.c</a>:</p>
<pre style='color:#555'>>  
-       /* copy **lines into 'new_file' if it is not FALSE(not duplicate) */
-       for(i = 0; i < total_num_lines; i++)
+       /* copy **lines into 'new_file' if it is not FALSE (not duplicate) */
+       for(i = 0; i < num_lines; i++)
</pre>
<p>num_lines > 0</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/378#pullrequestreview-15014760">lineoperations/src/linefunctions.c</a>:</p>
<pre style='color:#555'>>  
 
        /* allocate and set *to_remove to all TRUE
         * to_remove[i] represents whether lines[i] should be removed */
-       to_remove = g_malloc(sizeof(gboolean) * total_num_lines);
-       for(i = 0; i < total_num_lines; i++)
+       to_remove = g_malloc(sizeof(gboolean) * num_lines);
+       for(i = 0; i < num_lines; i++)
</pre>
<p>num_lines > 0</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/378#pullrequestreview-15014760">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-SBu54smXmEtgOLLEX0Ukj3lFx8ks5rOr-pgaJpZM4HlGtZ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ-NAjtQjydAiE1jVXNA7s0mRwumpks5rOr-pgaJpZM4HlGtZ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/378#pullrequestreview-15014760"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@frlan commented on #378"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/378#pullrequestreview-15014760"}}}</script>