<p>One disadvantage of the config-file-only approach is there's no type check at all and if you misspell some key name, the keybinding will be wrong (or probably unset, I don't know what GTK will do about this). So maybe for the "master" defaults it's better to have them in the code with at least some basic type-checking.</p>
<p>I'll try to prepare a patch - but <a href="https://github.com/thewhitetulip" class="user-mention">@thewhitetulip</a> I'd ask you to prepare the file with the keybinding overrides for Mac (for the keybindings I use I'm more or less fine with the way it is).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/issues/1324#issuecomment-266429012">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ5ljBjqzKv6BCzcycroS2Fd8_gtAks5rHUnbgaJpZM4K9DWQ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ4uYtyNZPx4oMjAoxwIgf5bjKRgKks5rHUnbgaJpZM4K9DWQ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/issues/1324#issuecomment-266429012"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee in #1324: One disadvantage of the config-file-only approach is there's no type check at all and if you misspell some key name, the keybinding will be wrong (or probably unset, I don't know what GTK will do about this). So maybe for the \"master\" defaults it's better to have them in the code with at least some basic type-checking.\r\n\r\nI'll try to prepare a patch - but @thewhitetulip I'd ask you to prepare the file with the keybinding overrides for Mac (for the keybindings I use I'm more or less fine with the way it is)."}],"action":{"name":"View Issue","url":"https://github.com/geany/geany/issues/1324#issuecomment-266429012"}}}</script>