<p><a href="https://github.com/b4n" class="user-mention">@b4n</a>, as you suspected this does have a side effect, <code>goto tag definition</code> and <code>goto_tag declaration</code> are no longer distinguishable and both pop up the list.</p>
<p>I traced <code>geany.glade</code> to <code>callbacks.c:on_goto_tag_definition1()</code> which calls <code>callbacks.c:goto_tag()</code> which calls <code>keybinding.c:keybindings_send_command()</code> which calls <code>keybindings.c:goto_tag()</code> which calls <code>symbols.c:symbols_goto_tag()</code> which calls <code>symbols.c:goto_tag()</code> which actually does something, thats three <code>goto_tag()</code> functions!!!!!!</p>
<p>The first <a href="https://github.com/geany/geany/blob/b29a973217979f8a32e47460cad8b2bac165ef47/src/symbols.c#L2065">line</a> seems to be the culprit.  The symbol needs to be a different type so it can be added to the <code>forward_type</code> list.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1313#issuecomment-261820597">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJzrqTtuCklFm5FJf4muDqScVFUhiks5rAO3xgaJpZM4K3jWL">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJxFteS8p4O7s0gJEBwzzlCkCBsF7ks5rAO3xgaJpZM4K3jWL.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1313#issuecomment-261820597"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1313: @b4n, as you suspected this does have a side effect, `goto tag definition` and `goto_tag declaration` are no longer distinguishable and both pop up the list.\r\n\r\nI traced `geany.glade` to `callbacks.c:on_goto_tag_definition1()` which calls `callbacks.c:goto_tag()` which calls `keybinding.c:keybindings_send_command()` which calls `keybindings.c:goto_tag()` which calls `symbols.c:symbols_goto_tag()` which calls `symbols.c:goto_tag()` which actually does something, thats three `goto_tag()` functions!!!!!!\r\n\r\nThe first [line](https://github.com/geany/geany/blob/b29a973217979f8a32e47460cad8b2bac165ef47/src/symbols.c#L2065) seems to be the culprit.  The symbol needs to be a different type so it can be added to the `forward_type` list."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1313#issuecomment-261820597"}}}</script>