<p><b>@kugel-</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1301#pullrequestreview-8313914">scripts/gtk-bundle-from-msys2.sh</a>:</p>
<pre style='color:#555'>> @@ -212,6 +212,10 @@ copy_grep_and_dependencies() {
        if [ "${own_arch}" == "${ABI}" -o -z "${MSYS2_ABI_PATH}" ]; then
                bin_dir="/usr/bin"
        else
+               # TODO we could maybe download MSYS2 from http://www2.futureware.at/~nickoe/msys2-mirror/distrib/
+               # extract the relevant files, download "grep" from
+               # http://www2.futureware.at/~nickoe/msys2-mirror/msys/${ABI}/grep-2.XX-1-${ABI}.pkg.tar.xz
+               # and so automate this even more than requiring an existing separate MSYS installation
</pre>
<p>I think this comment is weird. The script is meant to be run from an MSYS2 shell.</p>

<p>Besides, you can use pacman to download the archive files, the other parts of the bundle script do that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1301#pullrequestreview-8313914">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ8s_Vc_j_XKPXznK6mgL68MmKtXmks5q9vuAgaJpZM4KwqPQ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ0gt41b_gTfZt5TLVyMxHOGl7CUaks5q9vuAgaJpZM4KwqPQ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1301#pullrequestreview-8313914"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kugel- commented on #1301"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1301#pullrequestreview-8313914"}}}</script>