<p><b>@b4n</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1300">src/build.c</a>:</p>
<pre style='color:#555'>> @@ -826,14 +988,27 @@ static gchar *prepare_run_cmd(GeanyDocument *doc, gchar **working_dir, guint cmd
}
#endif
- run_cmd = build_create_shellscript(*working_dir, cmd_string, autoclose, &error);
- if (!run_cmd)
- {
- ui_set_statusbar(TRUE, _("Failed to execute \"%s\" (start-script could not be created: %s)"),
- !EMPTY(cmd_string_utf8) ? cmd_string_utf8 : NULL, error->message);
- g_error_free(error);
- g_free(*working_dir);
- }
+#ifdef G_OS_WIN32
+ /* Expand environment variables like %blah%. */
+ SETPTR(cmd_string, win32_expand_environment_variables(cmd_string));
+#endif
+
+ gchar *helper = g_build_filename(utils_resource_dir(RESOURCE_DIR_LIBEXEC), "geany-run-helper", NULL);
</pre>
<p>Yes, but I think it should be added after (e.g. is slightly out of scope here)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1300">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ0r1m6JMRmoRPEztUv4xLqw7yqH_ks5q9jmGgaJpZM4Kwec-">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ7L5Fwf4nSyg_ZEoJplb3Jv9B1cjks5q9jmGgaJpZM4Kwec-.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/geany/geany/pull/1300"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1300"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1300"}}}</script>