<p><b>@codebrainz</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1300#pullrequestreview-8303608">src/build.c</a>:</p>
<pre style='color:#555'>> +} Placeholder;
+
+
+static const gchar *placeholder_replacement(Placeholder *placeholders, size_t n_placeholders, gchar placeholder)
+{
+       for (size_t i = 0; i < n_placeholders; i++)
+       {
+               if (placeholders[i].placeholder == placeholder)
+                       return placeholders[i].replacement;
+       }
+
+       return NULL;
+}
+
+
+/* Replaces %s-style placeholders in a string.
</pre>
<p>Just out of curiosity, why not using template-style placeholders and re-using the template replacement code?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1300#pullrequestreview-8303608">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ03Xn7TfeNcBwa7EuXtL733I4-Paks5q9hszgaJpZM4Kwec-">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJzvumP3gm13wiGYBJGovmOFyrhmgks5q9hszgaJpZM4Kwec-.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1300#pullrequestreview-8303608"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz commented on #1300"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1300#pullrequestreview-8303608"}}}</script>