<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1258">src/win32.c</a>:</p>
<pre style='color:#555'>> @@ -1032,4 +1032,31 @@ gchar *win32_get_user_config_dir(void)
        return g_build_filename(g_get_user_config_dir(), "geany", NULL);
 }
 
+
+void win32_make_argc_and_argv_in_utf8(gint *pargc, gchar ***pargv)
+{
+       int num_arg;
+       LPWSTR *szarglist = CommandLineToArgvW(GetCommandLineW(), &num_arg);
+       char **utf8argv = g_new0(char *, num_arg + 1);
+       int i = num_arg;
+       while(i)
+       {
+               i--;
+               utf8argv[i] = g_utf16_to_utf8((gunichar2 *)szarglist[i], -1, NULL, NULL, NULL);
</pre>
<p>Well it's totally doable, but it involves calling <code>WideCharToMultiByte()</code> twice (or over-alloc <code>len*4+1</code> bytes), allocating manually and the like.  Indeed nothing complicated, but at least 4 lines or so worth of WINAPI code, where we basically have access to a 1-line thing.  So if it gives us something, yeah sure, otherwise I'm not really sure it's worth it.</p>

<p>Hell, let's see how it'd look:</p>

<div class="highlight highlight-source-c"><pre><span class="pl-k">static</span> gchar *<span class="pl-en">wcstr_to_utf8</span>(<span class="pl-c1">wchar_t</span> *wcstr)
{
    <span class="pl-k">int</span> len = <span class="pl-c1">WideCharToMultiByte</span>(CP_UTF8, <span class="pl-c1">0</span>, wcstr, -<span class="pl-c1">1</span>, <span class="pl-c1">NULL</span>, <span class="pl-c1">0</span>, <span class="pl-c1">NULL</span>, <span class="pl-c1">NULL</span>);
    gchar *utf8str = <span class="pl-c1">g_malloc</span>(len + <span class="pl-c1">1</span>);
    <span class="pl-c1">WideCharToMultiByte</span>(CP_UTF8, <span class="pl-c1">0</span>, wcstr, -<span class="pl-c1">1</span>, utf8str, len + <span class="pl-c1">1</span>, <span class="pl-c1">NULL</span>, <span class="pl-c1">NULL</span>);
    utf8str[len] = <span class="pl-c1">0</span>; <span class="pl-c">// FIXME: is that useful?</span>
    <span class="pl-k">return</span> utf8str;
}</pre></div>

<p>And according to the <a href="https://msdn.microsoft.com/en-us/library/windows/desktop/dd374130%28v=vs.85%29.aspx">docs</a> it probably doesn't really help:</p>

<blockquote>
<p><strong>WC_ERR_INVALID_CHARS</strong>: <strong>Windows Vista and later:</strong> Fail if an invalid input character is encountered. If this flag is not set, the function silently drops illegal code points. A call to GetLastError returns ERROR_NO_UNICODE_TRANSLATION. Note that this flag only applies when CodePage is specified as CP_UTF8 or 54936 (for Windows Vista and later). It cannot be used with other code page values.</p>
</blockquote>

<p>So my understanding would be that in case of invalid UTF-16 (as it is possible in filenames), it would result in uninteresting UTF-8, while we'd actually want "WTF-8".</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1258">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ7doExJt_KID9tjLrXs0pHcDK3R3ks5q8fHngaJpZM4KPpLl">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ-hJ3GB2auZzKY16B2lj2MbE3qzLks5q8fHngaJpZM4KPpLl.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1258"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1258"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1258"}}}</script>