<p><b>@eht16</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1258#pullrequestreview-7732004">src/win32.c</a>:</p>
<pre style='color:#555'>> @@ -1032,4 +1032,31 @@ gchar *win32_get_user_config_dir(void)
        return g_build_filename(g_get_user_config_dir(), "geany", NULL);
 }
 
+
+void win32_make_argc_and_argv_in_utf8(gint *pargc, gchar ***pargv)
</pre>
<p>Maybe <code>win32_convert_argv_to_utf8()</code> would be a better name.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1258#pullrequestreview-7732004">src/win32.c</a>:</p>
<pre style='color:#555'>> +{
+       int num_arg;
+       LPWSTR *szarglist = CommandLineToArgvW(GetCommandLineW(), &num_arg);
+       char **utf8argv = g_new0(char *, num_arg + 1);
+       int i = num_arg;
+       while(i)
+       {
+               i--;
+               utf8argv[i] = g_utf16_to_utf8((gunichar2 *)szarglist[i], -1, NULL, NULL, NULL);
+       }
+       *pargc = num_arg;
+       *pargv = utf8argv;
+       LocalFree(szarglist);
+}
+
+void win32_free_argv_made_in_utf8(gint argc, gchar **argv)
</pre>
<p>The code is quite generic and not Windows-specific, so it could go into src/utils.c as <code>utils_free_argv()</code>, similar to <code>utils_free_pointers()</code>.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1258#pullrequestreview-7732004">src/libmain.c</a>:</p>
<pre style='color:#555'>> @@ -1231,6 +1230,9 @@ gint main_lib(gint argc, gchar **argv)
 #endif
 
        gtk_main();
+#ifdef G_OS_WIN32
+       win32_free_argv_made_in_utf8(argc, argv);
</pre>
<p>Maybe the call including the G_OS_WIN32 guard could go into a seperate function in src/libmain.c as it should be also in <a href="https://github.com/geany/geany/blob/master/src/libmain.c#L1090">https://github.com/geany/geany/blob/master/src/libmain.c#L1090</a>.<br>
Strictly there are more places where it should be called, e.g. every place where we call <code>exit()</code> but this would require some refactoring before which is out of scope of this PR (and technically it is not very necessary as the memory in cleaned up anyway on <code>exit()</code>).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1258#pullrequestreview-7732004">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ6h__PpPJHmXRKWyq7qdJ7AELDpYks5q8QWJgaJpZM4KPpLl">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ9pVF7bJgLYx2NYvGXxDjZgynrH9ks5q8QWJgaJpZM4KPpLl.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1258#pullrequestreview-7732004"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eht16 commented on #1258"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1258#pullrequestreview-7732004"}}}</script>