<p><b>@elextr</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1282#pullrequestreview-6346635">HACKING</a>:</p>
<pre style='color:#555'>> @@ -200,8 +200,18 @@ Coding
   moment, we want to keep the minimum requirement for GTK at 2.24 (of
   course, you can use the GTK_CHECK_VERSION macro to protect code using
   later versions).
-* Variables should be declared before statements. You can use
-  gcc's -Wdeclaration-after-statement to warn about this.
+* Variables should be declared (and initialized) as close as practical
+  to their first use. This reduces the chances of intervening code being
+  inserted between declaration and use, where the variable may be
+  uninitialized.
+* Variables should be defined within the smallest scope that is practical,
+  for example inside a conditional branch which uses them or in the
+  initialization part of a for loop.
+* Local variables that will not be modified should be marked as ``const``
+  to indicate intention. This allows the compiler to give a warning if
+  part of the code accidentally tries to change the value. This does not
+  apply to non-pointer parameters where it needlessly exposes the
</pre>
<p>Suggest that the fact that pointer params that do not change what is pointed to should be declared const is important enough for its own bullet point.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1282#pullrequestreview-6346635">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ2pQL8T7ebulFtZQgmz2uQsTm5gZks5q4zlygaJpZM4KkGJE">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJwaqOpHAqqxFIPlLcNunDsrhunTNks5q4zlygaJpZM4KkGJE.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1282#pullrequestreview-6346635"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr commented on #1282"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1282#pullrequestreview-6346635"}}}</script>