<p><b>@codebrainz</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1280">src/symbols.c</a>:</p>
<pre style='color:#555'>> @@ -2289,6 +2290,32 @@ static gint get_fold_header_after(ScintillaObject *sci, gint line)
 }
 
 
+/* returns the line after following all brace match for @brace on @line */
+static gint resolve_matching_braces(ScintillaObject *sci, gint line, gint brace)
+{
+       gint pos = sci_get_position_from_line(sci, line);
+       gint line_end = sci_get_line_end_position(sci, line);
+       gint lexer = sci_get_lexer(sci);
</pre>
<p>I propose something like the following changes to <code>HACKING</code>:</p>

<div class="highlight highlight-source-diff"><pre><span class="pl-c1">diff --git a/HACKING b/HACKING</span>
index 938688d..13e4025 100644
<span class="pl-md">--- a/HACKING</span>
<span class="pl-mi1">+++ b/HACKING</span>
<span class="pl-mdr">@@ -200,8 +200,18 @@</span> Coding
   moment, we want to keep the minimum requirement for GTK at 2.24 (of
   course, you can use the GTK_CHECK_VERSION macro to protect code using
   later versions).
<span class="pl-md">-* Variables should be declared before statements. You can use</span>
<span class="pl-md">-  gcc's -Wdeclaration-after-statement to warn about this.</span>
<span class="pl-mi1">+* Variables should be declared (and initialized) as close as practical</span>
<span class="pl-mi1">+  to their first use. This reduces the chances of intervening code being</span>
<span class="pl-mi1">+  inserted between declaration and use, where the variable may be</span>
<span class="pl-mi1">+  uninitialized.</span>
<span class="pl-mi1">+* Variables should be defined within the smallest scope that is practical,</span>
<span class="pl-mi1">+  for example inside a conditional branch which uses them or in the</span>
<span class="pl-mi1">+  initialization part of a for loop.</span>
<span class="pl-mi1">+* Local variables that will not be modified should be marked as ``const``</span>
<span class="pl-mi1">+  to indicate intention. This allows the compiler to give a warning if</span>
<span class="pl-mi1">+  part of the code accidentally tries to change the value. This does not</span>
<span class="pl-mi1">+  apply to by-value parameters where it needlessly exposes the</span>
<span class="pl-mi1">+  implementation and it's obvious a copy is made anyway.</span>
 * Don't let variable names shadow outer variables - use gcc's -Wshadow
   option.
 * Do not use G_LIKELY or G_UNLIKELY (except in critical loops). These</pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1280">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ2YxpZ8VwACZELno35Z2ortV-mdrks5q4ypngaJpZM4Kig7l">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ9vs4nyGrAB5fd-2hpe-XRWDYvhdks5q4ypngaJpZM4Kig7l.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1280"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz commented on #1280"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1280"}}}</script>