<blockquote>
<p>Hum, if the new proposed API is case-sensitive and the previous wasn't, it could be a problem if it's not clear enough in the docs.</p>
</blockquote>

<p>I don't think so since it should do what is expected for filenames (see below).</p>

<blockquote>
<p>Also, how does it affect Windows? (where filesystem names are case insensitive I believe)</p>
</blockquote>

<p>It basically fixes non-Windows and "breaks" Windows. In one of the intermediate commits on this branch where I added support for the dot but before using pattern matching, I had accounting for this by adding a conditional code to do proper UTF-8 windows case insensitive comparison, but it doesn't apply this this.</p>

<p>One way to support it would be to casefold all of the extensions and casefold the filename and then compare them in a <code>#if</code> for Windows.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1236#issuecomment-257092216">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ2jbgHV-YGAbpq6GGvc-Gxw9hR4wks5q40ysgaJpZM4J_6i1">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ8VCEq-5b8WHAWRnmwr_TT9YXAcDks5q40ysgaJpZM4J_6i1.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1236#issuecomment-257092216"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz in #1236: \u003e Hum, if the new proposed API is case-sensitive and the previous wasn't, it could be a problem if it's not clear enough in the docs.\r\n\r\nI don't think so since it should do what is expected for filenames (see below).\r\n\r\n\u003e Also, how does it affect Windows? (where filesystem names are case insensitive I believe)\r\n\r\nIt basically fixes non-Windows and \"breaks\" Windows. In one of the intermediate commits on this branch where I added support for the dot but before using pattern matching, I had accounting for this by adding a conditional code to do proper UTF-8 windows case insensitive comparison, but it doesn't apply this this.\r\n\r\nOne way to support it would be to casefold all of the extensions and casefold the filename and then compare them in a `#if` for Windows."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1236#issuecomment-257092216"}}}</script>