<p><b>@codebrainz</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1280">src/symbols.c</a>:</p>
<pre style='color:#555'>> @@ -2289,6 +2290,32 @@ static gint get_fold_header_after(ScintillaObject *sci, gint line)
 }
 
 
+/* returns the line after following all brace match for @brace on @line */
+static gint resolve_matching_braces(ScintillaObject *sci, gint line, gint brace)
+{
+       gint pos = sci_get_position_from_line(sci, line);
+       gint line_end = sci_get_line_end_position(sci, line);
+       gint lexer = sci_get_lexer(sci);
</pre>
<blockquote>
<p>I find this overlong precondition hides the logic of the loop (condition and post-body).</p>
</blockquote>

<p>You could insert another line break instead of tucking it at the end of the last initializer line.</p>

<blockquote>
<p>Anyway, the new code is different, do you still think I should so something like that now the 2 other variables are constant?</p>
</blockquote>

<p>My opinion is that doing so should be the default unless there is a reason not to, for example to keep it out of the loop for performance reasons, or I suppose in this case to have them be <code>const</code>. That being said, using <code>const</code> like that is also not used often in Geany and is something else that should either be done all the time or not. I think we should update <code>HACKING</code> to indicate both of these (though I'm not convinced we want to sprinkle <code>const</code> everywhere, personally).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1280">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ5H50XRTXOvcamlxiogTqVaUSXU8ks5q4yWwgaJpZM4Kig7l">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ5M3ZIlm3chGufcyCzQPLcZZPHI8ks5q4yWwgaJpZM4Kig7l.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1280"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz commented on #1280"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1280"}}}</script>