<p>I moved most code to win32.c, and included argv[0] in conversion.</p>

<p>Different file systems can use various encoding for filenames. (NTFS, FAT32, etc.) But <code>CommandLineToArgvW</code> always provide filenames in UTF-16. So in the case of windows api functions, underlying file system usually should not be a problem.</p>

<p>It's easy to get some random CJK characters from typing code unit. (Ctrl+Shift+I on firefox/chrome, in the console, type '\u6666')</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1258#issuecomment-256847252">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJzV3JHozS09qssEZx0ZRiW2eDoAOks5q4ZgJgaJpZM4KPpLl">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ0GlXcZ5bIdcYjxRYKBMMInbo0ggks5q4ZgJgaJpZM4KPpLl.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1258#issuecomment-256847252"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cshu in #1258: I moved most code to win32.c, and included argv[0] in conversion.\r\n\r\nDifferent file systems can use various encoding for filenames. (NTFS, FAT32, etc.) But `CommandLineToArgvW` always provide filenames in UTF-16. So in the case of windows api functions, underlying file system usually should not be a problem.\r\n\r\nIt's easy to get some random CJK characters from typing code unit. (Ctrl+Shift+I on firefox/chrome, in the console, type '\\u6666')"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1258#issuecomment-256847252"}}}</script>