<blockquote>
<p>That said, if this PR includes any files that are not used in any way, it makes no sense to include them, we should do like we do with Scintilla and leave out completely unused files, IMO.</p>
</blockquote>

<p>I just did it for a few files (should be around -4000LOCs in total) but even though some more files look they might be removed too as we don't need their implementation, it's not so easy as they are called from other files (in functions which don't get called by Geany). But this is what would need quite some refactoring and it's something I'd leave for the uctags patches.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1263#issuecomment-255732592">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ0YbU4QTDRV_LWRr1tZ3jWuFeZNTks5q3KsUgaJpZM4KXvBh">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJw6VIWrFCE1UxJjpR0Z8hTcORm0qks5q3KsUgaJpZM4KXvBh.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1263#issuecomment-255732592"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee in #1263: \u003e That said, if this PR includes any files that are not used in any way, it makes no sense to include them, we should do like we do with Scintilla and leave out completely unused files, IMO.\r\n\r\nI just did it for a few files (should be around -4000LOCs in total) but even though some more files look they might be removed too as we don't need their implementation, it's not so easy as they are called from other files (in functions which don't get called by Geany). But this is what would need quite some refactoring and it's something I'd leave for the uctags patches.\r\n\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1263#issuecomment-255732592"}}}</script>