<p><b>@b4n</b> requested changes on this pull request.</p>

<p>LGTM apart the small typo and the merge conflict.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/1223#pullrequestreview-5366433">src/geanyobject.c</a>:</p>
<pre style='color:#555'>> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
                G_SIGNAL_RUN_FIRST,
                0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
                G_TYPE_NONE, 0);
+       geany_object_signals[GDB_PROJECT_BEFORE_CLOSE] = g_signal_new (
</pre>
<p>typo: prefix should be <code>GCB_</code>, not <code>GDB_</code></p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1223#pullrequestreview-5366433">src/geanyobject.h</a>:</p>
<pre style='color:#555'>> @@ -47,6 +47,7 @@ typedef enum
        GCB_PROJECT_OPEN,
        GCB_PROJECT_SAVE,
        GCB_PROJECT_CLOSE,
+       GDB_PROJECT_BEFORE_CLOSE,
</pre>
<p>Ditto</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1223#pullrequestreview-5366433">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ1FDdoQIh_5QGKhLJvT7bsB8nJecks5q23bmgaJpZM4J54Jy">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ6mhnKQZwlNx_jEm60_qNNx8wpv7ks5q23bmgaJpZM4J54Jy.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1223#pullrequestreview-5366433"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n requested changes on #1223"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1223#pullrequestreview-5366433"}}}</script>