<p><b>@b4n</b> commented on this pull request.</p>

<p>Breaks API (as the semantics of proxy registration changed).</p>

<p>Though, the new API makes sense to me, at least in theory.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/1236#pullrequestreview-5366539">src/plugins.c</a>:</p>
<pre style='color:#555'>>       * but not a problem in practice yet */
        foreach_list(node, active_proxies.head)
        {
                PluginProxy *proxy = node->data;
-               if (utils_str_casecmp(ext, proxy->extension) == 0)
+               if (g_pattern_match(proxy->glob, strlen(file), file, NULL))
</pre>
<p>maybe cache the result of <code>strlen(file)</code> outside the loop?</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1236#pullrequestreview-5366539">src/plugins.c</a>:</p>
<pre style='color:#555'>> @@ -1344,6 +1347,10 @@ void plugins_init(void)
        g_signal_connect(geany_object, "save-settings", G_CALLBACK(update_active_plugins_pref), NULL);
        stash_group_add_string_vector(group, &active_plugins_pref, "active_plugins", NULL);
 
+       builtin_proxy_glob = g_strconcat("*.", G_MODULE_SUFFIX, NULL);
+       builtin_so_proxy.glob = g_pattern_spec_new(builtin_proxy_glob);
</pre>
<p>yeah</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1236#pullrequestreview-5366539">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ1Z1DocZDJaQTyTL6VD08IPaPgjDks5q23xsgaJpZM4J_6i1">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ6gSsPelnDiIJG1wowc_Sy-seno6ks5q23xsgaJpZM4J_6i1.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1236#pullrequestreview-5366539"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1236"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1236#pullrequestreview-5366539"}}}</script>