<p><b>@b4n</b> commented on this pull request.</p>

<p>Looks mostly fine, see comments.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/1222#pullrequestreview-5366880">src/project.c</a>:</p>
<pre style='color:#555'>> + * This is done as if the user had done it using the `Project->Open`
+ * menu item (ie. it will confirm closing the current project). Any
+ * files in the project's session will be re-opened.
+ *
+ * @param project_locale_fn The filename of the project file in locale
+ * filename encoding.
+ *
+ * @return @c TRUE if the project was opened, @c FALSE otherwise.
+ *
+ * @since 1.29 (API 230)
+ */
+GEANY_API_SYMBOL
+gboolean project_open_file(const gchar *project_locale_fn)
+{
+       return (project_ask_close() &&
+               project_load_file_with_session(project_locale_fn));
</pre>
<p>It might make sense to perform the same checks as <code>osx.c</code> does, that is that the project file to open is not obviously the same as the currently open one:</p>

<div class="highlight highlight-source-c"><pre>    <span class="pl-k">if</span> (app->project == <span class="pl-c1">NULL</span> || 
        (g_strcmp0(utf8_path, app->project->file_name) != <span class="pl-c1">0</span> && project_ask_close()))
        <span class="pl-en">project_load_file_with_session</span>(locale_path);</pre></div>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1222#pullrequestreview-5366880">src/project.c</a>:</p>
<pre style='color:#555'>> +/**
+ * Open the given project file.
+ *
+ * This is done as if the user had done it using the `Project->Open`
+ * menu item (ie. it will confirm closing the current project). Any
+ * files in the project's session will be re-opened.
+ *
+ * @param project_locale_fn The filename of the project file in locale
+ * filename encoding.
+ *
+ * @return @c TRUE if the project was opened, @c FALSE otherwise.
+ *
+ * @since 1.29 (API 230)
+ */
+GEANY_API_SYMBOL
+gboolean project_open_file(const gchar *project_locale_fn)
</pre>
<p>This new API should probably be used in <code>osx.c</code>'s <code>open_project_idle()</code> and in <code>ui_utils.c</code>'s <code>recent_project_activate_cb()</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1222#pullrequestreview-5366880">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ0CoaTlrxMvfcrLu8dMc-indwSE-ks5q23-igaJpZM4J53Bf">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJykzlmcq5wnObpzisCh9MDZT6gxYks5q23-igaJpZM4J53Bf.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1222#pullrequestreview-5366880"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1222"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1222#pullrequestreview-5366880"}}}</script>