<p><a href="https://github.com/biv91" class="user-mention">@biv91</a> The basic file write method is intended to be simple and fast, especially useful for slow remote filesystems.  We regularly get complaints about other save methods being too slow.  Your changes mean it now writes all zeros and then overwrites with the data, potentially doubling the transfers.</p>

<p>Also that change has nothing to do with overwriting links on windows.  Please separate the changes.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1270#issuecomment-255500141">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJzrr2m27xizSse2HcjBdSZ1tym4oks5q2WvzgaJpZM4Kdr3G">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ23Ct15ILuC9oknyYLNZ9YA8cU8pks5q2WvzgaJpZM4Kdr3G.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1270#issuecomment-255500141"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1270: @biv91 The basic file write method is intended to be simple and fast, especially useful for slow remote filesystems.  We regularly get complaints about other save methods being too slow.  Your changes mean it now writes all zeros and then overwrites with the data, potentially doubling the transfers.\r\n\r\nAlso that change has nothing to do with overwriting links on windows.  Please separate the changes."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1270#issuecomment-255500141"}}}</script>