<p><a href="https://github.com/biv91" class="user-mention">@biv91</a> I say again do not change common code.  The simple unsafe saving code suits specific use-cases, and your half safe saving adds overheads that may not be wanted.  If you want another saving method, give it an option of its own and make it separate code.</p>

<p>If you just found the settings I suggest you read <a href="https://wiki.geany.org/config/all_you_never_wanted_to_know_about_file_saving">this</a> before you go changing a critical function such as file saving.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1270#issuecomment-255504195">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ3hlfmmgzyhsclr5Spu2Lht9srgOks5q2YA3gaJpZM4Kdr3G">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ9SBKHo0OXejitrAp_puSi6T5uGLks5q2YA3gaJpZM4Kdr3G.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1270#issuecomment-255504195"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1270: @biv91 I say again do not change common code.  The simple unsafe saving code suits specific use-cases, and your half safe saving adds overheads that may not be wanted.  If you want another saving method, give it an option of its own and make it separate code.\r\n\r\nIf you just found the settings I suggest you read [this](https://wiki.geany.org/config/all_you_never_wanted_to_know_about_file_saving) before you go changing a critical function such as file saving."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1270#issuecomment-255504195"}}}</script>