<blockquote>
<p>I pity anyone who tries to review the entire changeset :)</p>
</blockquote>

<p>This is why I'd suggest reviewing it as if it was a single commit</p>

<p>"Take over upstream ctags and apply Geany changes on top"</p>

<p>which is how it will appear when you take meld and compare upstream ctags/main with geany-ctags/main. The diff is just a few hundreds LOCs.</p>

<p>I did it this painful way myself to make sure nothing what Geany needs was lost on the way.</p>

<p>The only changes worth reviewing in greater detail are those that affect parsers (mostly cork introduction), lcpp.c changes and that's about it.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1263#issuecomment-254039919">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ8OtHsPg3BbtyZdkvhsJ5YXx18g0ks5q0gITgaJpZM4KXvBh">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ_zHYUty9OksDBo_LPJe2I2K5Dioks5q0gITgaJpZM4KXvBh.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1263#issuecomment-254039919"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee in #1263: \u003e I pity anyone who tries to review the entire changeset :)\r\n\r\nThis is why I'd suggest reviewing it as if it was a single commit\r\n\r\n\"Take over upstream ctags and apply Geany changes on top\"\r\n\r\nwhich is how it will appear when you take meld and compare upstream ctags/main with geany-ctags/main. The diff is just a few hundreds LOCs.\r\n\r\nI did it this painful way myself to make sure nothing what Geany needs was lost on the way.\r\n\r\nThe only changes worth reviewing in greater detail are those that affect parsers (mostly cork introduction), lcpp.c changes and that's about it."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1263#issuecomment-254039919"}}}</script>