<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/486#pullrequestreview-3432626">geanyprj/src/geanyprj.c</a>:</p>
<pre style='color:#555'>> @@ -74,6 +74,7 @@ static void reload_project(void)
        {
                if (g_current_project)
                        xproject_close(TRUE);
+               set_non_ft_build_wdir((gchar*)"");
</pre>
<p>should take a <code>const gchar *</code> as it doesn't need modifying the string anyway, and would remove the need for this odd cast</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/486#pullrequestreview-3432626">geanyprj/src/menu.c</a>:</p>
<pre style='color:#555'>> @@ -269,6 +284,7 @@ void on_preferences(G_GNUC_UNUSED GtkMenuItem *menuitem, G_GNUC_UNUSED gpointer
                geany_project_set_name(g_current_project, gtk_entry_get_text(GTK_ENTRY(e->name)));
                geany_project_set_description(g_current_project, "");
                geany_project_set_run_cmd(g_current_project, "");
+               geany_project_set_working_dir(g_current_project,  gtk_entry_get_text(GTK_ENTRY(e->working_dir)));
</pre>
<p>double space after the comma</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/486#pullrequestreview-3432626">geanyprj/src/utils.c</a>:</p>
<pre style='color:#555'>> @@ -275,3 +275,13 @@ GSList *get_file_list(const gchar *path, guint * length, gboolean(*func)(const g
        return list;
 }
 
+/* update Geany's non-filetype working directories in the build menu to wdir */
+void set_non_ft_build_wdir(gchar* wdir) {
+       gint i;
+       for(i = 0; i < build_get_group_count(GEANY_GBG_NON_FT); ++i)
+               build_set_menu_item(GEANY_BCS_PREF, /* medium priority */
+                                                       GEANY_GBG_NON_FT, /* non-filetype build entries */
+                                                       i,
+                                                       GEANY_BC_WORKING_DIR, /* working dir field */
+                                                       wdir);
</pre>
<p>braces around the <code>for</code> would be nice for readability IMO as the body spans multiple lines (even though it's a single statement so doesn't change meaning)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/486#pullrequestreview-3432626">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ6NgL547M5QLiNFLhbdT6kHTZh4iks5qyU0agaJpZM4KQOrP">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJwVsOuMXyQQVANeIpBEqnWnpmraoks5qyU0agaJpZM4KQOrP.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/486#pullrequestreview-3432626"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #486"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/486#pullrequestreview-3432626"}}}</script>