<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1255">src/libmain.c</a>:</p>
<pre style='color:#555'>>              main_quit();
        }
+       return G_SOURCE_REMOVE;
</pre>
<p>I guess it depends on whether or not returning <code>CONTINUE</code> will remove the signal handler altogether and restore the default action or not.</p>

<p>Because IMO</p>

<ul>
<li>it makes more sense to return <code>CONTINUE</code>, unless we <em>mean</em> not to handle the signal anymore</li>
<li>it is often customary to stop handling these kind of signals after receiving them for the first time, so that if the app still doesn't quit sending it again will just terminate it, just not necessarily cleanly.  So that might suggest <code>REMOVE</code>.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1255">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ0Feuw2dR60q5ZfrV5Hf032dZuR7ks5qw_96gaJpZM4KPCgU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ7piknytyRRsE7_6n6kp-yjGm0okks5qw_96gaJpZM4KPCgU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1255"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1255"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1255"}}}</script>