<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1255#pullrequestreview-2988792">src/libmain.c</a>:</p>
<pre style='color:#555'>>  {
+       gint sig = GPOINTER_TO_INT(user_data);
        if (sig == SIGTERM)
</pre>
<p>what about having a signal-specific callback instead of checking this?  <code>g_unix_signal_add()</code> can only get one signum at a time IIUC, so there doesn't seem to be any reason to reuse the same handler when the body will be totally different each time.</p>

<p>So I'd suggest renaming to something like <code>sigterm_handler()</code> or something, and remove the signum check (and passing it altogether).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1255#pullrequestreview-2988792">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-n_YUXoZoejQaywO28aP2vzzn6mks5qw_5XgaJpZM4KPCgU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJyFGDAtTzgnHQPdRg1YdX7iOqyJ7ks5qw_5XgaJpZM4KPCgU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1255#pullrequestreview-2988792"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1255"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1255#pullrequestreview-2988792"}}}</script>