<p><b>@b4n</b> commented on this pull request.</p>
<p>If we care about alignment, there are a few more to fix.<br>
Apart that, LGTM.</p><hr>
<p>In <a href="https://github.com/geany/geany/pull/1251#pullrequestreview-2714979">ctags/main/parse.c</a>:</p>
<pre style='color:#555'>> }
}
-static boolean enableLanguageKind (const langType language,
- const int kind, const boolean mode)
+static bool enableLanguageKind (const langType language,
+ const int kind, const bool mode)
</pre>
<p>alignment</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1251#pullrequestreview-2714979">ctags/main/parse.c</a>:</p>
<pre style='color:#555'>> @@ -526,10 +525,10 @@ static void processLangKindOption (const langType language,
}
}
-extern boolean processKindOption (const char *const option,
+extern bool processKindOption (const char *const option,
const char *const parameter)
</pre>
<p>alignment</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1251#pullrequestreview-2714979">ctags/main/parse.c</a>:</p>
<pre style='color:#555'>> tag.lineNumber = 1;
makeTagEntry (&tag);
}
}
-static boolean createTagsForFile (const char *const fileName,
+static bool createTagsForFile (const char *const fileName,
const langType language,
const unsigned int passCount)
</pre>
<p>ditto</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1251#pullrequestreview-2714979">ctags/main/parse.c</a>:</p>
<pre style='color:#555'>> @@ -636,13 +635,13 @@ static boolean createTagsForFile (const char *const fileName,
return retried;
}
-static boolean createTagsWithFallback (const char *const fileName,
+static bool createTagsWithFallback (const char *const fileName,
const langType language)
</pre>
<p>more</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1251#pullrequestreview-2714979">ctags/main/parse.h</a>:</p>
<pre style='color:#555'>> @@ -48,7 +48,7 @@ typedef struct {
const char* const name;
const char* const kinds;
const char *const flags;
- boolean *disabled;
+ bool *disabled;
</pre>
<p>more or less the same, but meh</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1251#pullrequestreview-2714979">ctags/main/read.h</a>:</p>
<pre style='color:#555'>> @@ -66,7 +66,7 @@ typedef struct sInputFileInfo {
when `resetInputFile' is called
on the input stream.
This is needed for nested stream. */
- boolean isHeader; /* is input file a header file? */
+ bool isHeader; /* is input file a header file? */
</pre>
<p>more</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1251#pullrequestreview-2714979">ctags/main/read.h</a>:</p>
<pre style='color:#555'>> @@ -78,8 +78,8 @@ typedef struct sInputFile {
MIOPos filePosition; /* file position of current line */
unsigned int ungetchIdx;
int ungetchBuf[3]; /* characters that were ungotten */
- boolean eof; /* have we reached the end of file? */
- boolean newLine; /* will the next character begin a new line? */
+ bool eof; /* have we reached the end of file? */
+ bool newLine; /* will the next character begin a new line? */
</pre>
<p>more or less</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1251#pullrequestreview-2714979">ctags/parsers/c.c</a>:</p>
<pre style='color:#555'>> @@ -1535,7 +1534,7 @@ static void qualifyCompoundTag (const statementInfo *const st,
const tagType type = declToTagType (st->declaration);
if (type != TAG_UNDEFINED)
- makeTag (nameToken, st, (boolean) (! isInputLanguage (Lang_java) &&
+ makeTag (nameToken, st, (bool) (! isInputLanguage (Lang_java) &&
! isInputLanguage (Lang_csharp) &&
! isInputLanguage (Lang_vala)), type);
</pre>
<p>more</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1251#pullrequestreview-2714979">ctags/parsers/c.c</a>:</p>
<pre style='color:#555'>> else if (isType (token, TOKEN_BRACE_CLOSE))
/* Java, D, C#, Vala do not require semicolons to end a block. Neither do
* C++ namespaces. All other blocks require a semicolon to terminate them.
*/
- isEnd = (boolean) (isInputLanguage (Lang_java) || isInputLanguage (Lang_d) ||
- isInputLanguage (Lang_csharp) || isInputLanguage (Lang_vala) ||
- ! isContextualStatement (st));
+ isEnd = (bool) (isInputLanguage (Lang_java) || isInputLanguage (Lang_d) ||
+ isInputLanguage (Lang_csharp) || isInputLanguage (Lang_vala) ||
+ ! isContextualStatement (st));
</pre>
<p><g-emoji alias="+1" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f44d.png" ios-version="6.0">👍</g-emoji> </p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1251#pullrequestreview-2714979">ctags/parsers/sh.c</a>:</p>
<pre style='color:#555'>> {
const char *const scriptName = baseFilename (getInputFileName ());
- boolean result = (boolean) (strcmp (scriptName, "configure") == 0 &&
+ bool result = (bool) (strcmp (scriptName, "configure") == 0 &&
strcmp (vStringValue (tagName), "main") == 0);
</pre>
<p>more</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1251#pullrequestreview-2714979">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ_sT_otxED-4RA1-9-EG01QgsS5Gks5qwmGPgaJpZM4KL4iS">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ88a79nO0DCLI6dl-qPHQayVp-cEks5qwmGPgaJpZM4KL4iS.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/geany/geany/pull/1251#pullrequestreview-2714979"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1251"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1251#pullrequestreview-2714979"}}}</script>