<p>The current state of the pull request looks like this.</p>

<pre><code>if( buffer.is_clean )
    if( auto_reload )
        if( file_prefs.keep_edit_history_on_reload ) //default=true
            possibleHighMemoryUsage();
        else
            possibleDataLoss();
</code></pre>

<p>It looks to me like we can remove the auto_reload option and make it automatic<br>
without data loss.</p>

<p>Am I correct in assuming you would prefer a finer-grained version of<br>
file_prefs.keep_edit_history_on_reload ??</p>

<p>If so, perhaps document_reload_force() and document_open_file_full() could be <br>
refactored to take a keep_undo_history parameter??</p>

<p>I do not consider changing the file monitor to be a part of this PR.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1246#issuecomment-250536557">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJztFYN37fC8JuT80cOzoeWoBBv0Sks5qu_Z9gaJpZM4KGa-x">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ4Ju9icjWru7cO5OktsO5PZJjTCtks5qu_Z9gaJpZM4KGa-x.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1246#issuecomment-250536557"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@shiftee in #1246: The current state of the pull request looks like this.\r\n```\r\nif( buffer.is_clean )\r\n\tif( auto_reload )\r\n\t\tif( file_prefs.keep_edit_history_on_reload ) //default=true\r\n\t\t\tpossibleHighMemoryUsage();\r\n\t\telse\r\n\t\t\tpossibleDataLoss();\r\n```\r\nIt looks to me like we can remove the auto_reload option and make it automatic\r\nwithout data loss.\r\n\r\nAm I correct in assuming you would prefer a finer-grained version of\r\nfile_prefs.keep_edit_history_on_reload ??\r\n\r\nIf so, perhaps document_reload_force() and document_open_file_full() could be \r\nrefactored to take a keep_undo_history parameter??\r\n\r\nI do not consider changing the file monitor to be a part of this PR."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1246#issuecomment-250536557"}}}</script>