<blockquote>
<p>As the discussion reads from here, it looks like you ignored it.</p>
</blockquote>

<p>I kind of did ignore it, because as I understood what he meant was to use <code>g_error()</code> or alike and crash Geany, which sounded kind of harsh/insane. This was possibly a misunderstanding on my part though. Since it was such a trivial patch and the number of people who will encounter this code path so small, I figured I'd just make an "executive decision" so to speak.</p>

<blockquote>
<p>Same with showing the plugin name in the warning (<a href="https://github.com/geany/geany/pull/1212" class="issue-link js-issue-link" data-url="https://github.com/geany/geany/issues/1212" data-id="175140331" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#1212</a> (comment)) -- probably a mere forgetfulness, though.</p>
</blockquote>

<p>That was indeed forgetfulness (or rather misreading), I missed your comment when reviewing the comments before merging.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1212#issuecomment-247566056">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-MeTumMF_BHgOgdrMIstjfVXRdyks5qqmwEgaJpZM4J1X_v">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ12-_gkE_jCOhrDGFg9NsDx62x3Xks5qqmwEgaJpZM4J1X_v.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1212#issuecomment-247566056"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz in #1212: \u003e As the discussion reads from here, it looks like you ignored it.\r\n\r\nI kind of did ignore it, because as I understood what he meant was to use `g_error()` or alike and crash Geany, which sounded kind of harsh/insane. This was possibly a misunderstanding on my part though. Since it was such a trivial patch and the number of people who will encounter this code path so small, I figured I'd just make an \"executive decision\" so to speak.\r\n\r\n\u003e Same with showing the plugin name in the warning (#1212 (comment)) -- probably a mere forgetfulness, though.\r\n\r\nThat was indeed forgetfulness (or rather misreading), I missed your comment when reviewing the comments before merging.\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1212#issuecomment-247566056"}}}</script>