<p>The ways on how a "folder name string" should be created and compared is divided in many parts of <code>get_doc_parent()</code> and the functions it call.  One is from <code>get_folder_name()</code> itself, another is from <code>find_tree_iter_dir()</code> (<code>if (utils_str_equal(dir, ".")) dir = GEANY_STRING_UNTITLED;</code>), and another in the assignment of the item to <code>store_openfiles</code> (<code>DOCUMENTS_SHORTNAME, doc->file_name ? dirname : GEANY_STRING_UNTITLED</code>).</p>

<p>The ambiguity causes issues like having multiple parents in the Documents list that has the name <code>.</code> when the filename has a basename but not a directory name.  This can be done by creating multiple new files with a template.</p>

<p>This patch is basically an overhaul to fix the ambiguity, and the issue is fixed along with it.  If <code>get_folder_name()</code> is shared and used somewhere else besides <code>sidebar.c</code>, it would no longer require a wrapper just to make the returned string consistent.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/geany/geany/pull/1199'>https://github.com/geany/geany/pull/1199</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix new files created with template not being placed in 'untitled' folder</li>
  <li>Place everything about creating document folder string in get_doc_folder()</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1199/files#diff-0">src/sidebar.c</a>
    (128)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/geany/geany/pull/1199.patch'>https://github.com/geany/geany/pull/1199.patch</a></li>
  <li><a href='https://github.com/geany/geany/pull/1199.diff'>https://github.com/geany/geany/pull/1199.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1199">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJyRSXX0LelGYNoDrIxjv0YTuc2aiks5qlCjSgaJpZM4Jwftc">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ6mxaJk8XwZhtX6E18bX5bQ-v8PAks5qlCjSgaJpZM4Jwftc.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1199"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Rearrange get_doc_parent(); Place everything about creating the folder string to get_folder_name() (#1199)"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1199"}}}</script>