<p>As discussed in <a href="https://github.com/geany/geany/pull/1180" class="issue-link js-issue-link" data-url="https://github.com/geany/geany/issues/1180" data-id="171848150" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#1180</a>.</p>

<p>This change adds two new functions: <code>document_rename_file_and_save()</code>, and <code>document_rename_and_save()</code>.  <code>document_rename_file_and_save()</code> is kind of like the combination of <code>document_rename_file()</code> and <code>document_save_file_as()</code>, and is strictly about renaming the associated file, and doing the stuff necessary before and after the file has been renamed, like disabling file monitoring, and putting it back if a rename fails, saving/restoring file disk status, etc.</p>

<p><code>document_rename_and_save()</code> OTOH is more of a wrapper, and is about renaming the document itself.  It doesn't require the document to have an associated file to it (i.e. <code>doc->real_path != NULL</code>).  But if there is an associated file, the file is also renamed, i.e., <code>document_rename_file_and_save()</code> is called.  The algorithm to check if the file has to be overwritten is also contained in it.  This function should be adaptable to other implementations like <a href="https://github.com/konsolebox/geany/tree/docs_rename">in-place renaming</a>.</p>

<p>In <code>dialogs.c</code>, stuff about resetting <code>doc->tm_file</code> and calling <code>build_menu_update()</code> has been moved to <code>document_save_file_as()</code>, since both are essentially needed to be done by anyone that calls the function. It helps significantly simplify the two new functions and the functions in <code>dialogs.c</code>.</p>

<p>The function <code>save_as_dialog_handle_response()</code> has been refactored, and is now simpler since the "overwrite file?" prompt has been moved to <code>document_rename_and_save()</code>, and since it can now directly call <code>document_rename_and_save()</code> and <code>document_save_file_as()</code>.  <code>dialogs_show_save_as()</code> now also directly calls <code>document_save_file_as()</code> if <code>interface_prefs.use_native_windows_dialogs == TRUE</code>.  <code>handle_save_as()</code> is no longer needed, so it's been removed.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/geany/geany/pull/1194'>https://github.com/geany/geany/pull/1194</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Add document_rename_file_and_save()</li>
  <li>Do not make document_rename_file_and_save() an API function for now</li>
  <li>Add document_rename_and_save()</li>
  <li>Move resetting GeanyDocument::tm_file, and calling build_menu_update() to document_save_file_as()</li>
  <li>Rework Save-As functions in dialogs.c</li>
  <li>dialogs_show_save_as: g_free(utf8_name);</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1194/files#diff-0">src/dialogs.c</a>
    (78)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1194/files#diff-1">src/document.c</a>
    (81)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/1194/files#diff-2">src/document.h</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/geany/geany/pull/1194.patch'>https://github.com/geany/geany/pull/1194.patch</a></li>
  <li><a href='https://github.com/geany/geany/pull/1194.diff'>https://github.com/geany/geany/pull/1194.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1194">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ36V2pqtVGxZ9KlulQRtAwNiOeUfks5qjhC1gaJpZM4JtjDq">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ8MPrLEO3B5xNBt9UL7pEZm8-n2Qks5qjhC1gaJpZM4JtjDq.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1194"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Rework Save-As; Abort saving if rename fails (#1194)"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1194"}}}</script>