<p><a href="https://github.com/techee" class="user-mention">@techee</a> ATM it shows so much irrelevant shit that its not useful, at least this trims it somewhat.</p>

<p>Including something in the list because it <em>might</em> be relevant due to a local import we don't parse is not right.  The right thing is to parse local declarations and that would include imports, then we know which names are available, including the locals which are <em>not</em> included ATM.</p>

<p>Basically this PR and the other similar ones is what we call here "putting lipstick on a pig", they are not addressing the real problem and spending lots of effort fiddling around the edges for no gain.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1188#issuecomment-242367242">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJzaXKjHxVngqI_CpvfYa36v4GZJ5ks5qjYl1gaJpZM4JqXyT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJxOnBzTFmYcJmSA-8aiWSpHfTkppks5qjYl1gaJpZM4JqXyT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1188#issuecomment-242367242"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1188: @techee ATM it shows so much irrelevant shit that its not useful, at least this trims it somewhat.\r\n\r\nIncluding something in the list because it _might_ be relevant due to a local import we don't parse is not right.  The right thing is to parse local declarations and that would include imports, then we know which names are available, including the locals which are _not_ included ATM.\r\n\r\nBasically this PR and the other similar ones is what we call here \"putting lipstick on a pig\", they are not addressing the real problem and spending lots of effort fiddling around the edges for no gain."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1188#issuecomment-242367242"}}}</script>