<blockquote>
<p>Going back to the original issues, do you still think we shouldn't abort saving changes when a rename fails?</p>
</blockquote>

<p>Well, since the rename operation is an integral part of the semantics of the "rename" version of "save as", yes it should abort if it can't do it.  </p>

<p>Closing in favour of <a href="https://github.com/geany/geany/pull/1180" class="issue-link js-issue-link" data-url="https://github.com/geany/geany/issues/1180" data-id="171848150" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#1180</a>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1190#issuecomment-242034557">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJxEMuOxdVF80JY28UUkP-WGhILQvks5qjC3UgaJpZM4JrfCw">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ8KpZnMKhlAKCzYFFsZ-IW3VlwtXks5qjC3UgaJpZM4JrfCw.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1190#issuecomment-242034557"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1190: \u003e Going back to the original issues, do you still think we shouldn't abort saving changes when a rename fails?\r\n\r\nWell, since the rename operation is an integral part of the semantics of the \"rename\" version of \"save as\", yes it should abort if it can't do it.  \r\n\r\nClosing in favour of #1180."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1190#issuecomment-242034557"}}}</script>