<p>In <a href="https://github.com/geany/geany/pull/1187#discussion_r75811952">src/tagmanager/tm_query.c</a>:</p>
<pre style='color:#555'>> +            {
> +                  tags = tm_tags_find(q->workspace->tags_array, s->str, s->len, &ntags);
> +                  foreach_c_array(ptag, tags, ntags)
> +                          g_queue_insert_sorted(&res, *ptag, tag_compare_ptr, &sort_options);
> +          }
> +  }
> +
> +  /* Filter tags according to scope, type and lang. */
> +  for (node = res.head; node; node = next)
> +  {
> +          gboolean match = TRUE;
> +
> +          next = node->next;
> +          tag = node->data;
> +          foreach_ptr_array(scope, i, q->scopes)
> +                  match = match && (g_strcmp0(tag->scope, scope) == 0);
</pre>
<p>I'm not worried about best possible speed, just about not being super slow. The performance problem with the global tag array I mentioned is half a second UI freeze (for each global_tags and tag_array) on the first access. This is unbearable.</p>

<p>For this code I care a bit more about readability. I tried to add some breaks there but it would really be ugly IMO.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1187/files/386006313a0b78c614bd1ac522ac121e093df58d#r75811952">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJzZ4XMPDV0-Pa-DlECr9mpwy64Ipks5qipuJgaJpZM4JqVBL">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ288UyMCcH7GbiXNAuFKYVaVEnu9ks5qipuJgaJpZM4JqVBL.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1187/files/386006313a0b78c614bd1ac522ac121e093df58d#r75811952"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@kugel- in #1187: I'm not worried about best possible speed, just about not being super slow. The performance problem with the global tag array I mentioned is half a second UI freeze (for each global_tags and tag_array) on the first access. This is unbearable.\r\n\r\nFor this code I care a bit more about readability. I tried to add some breaks there but it would really be ugly IMO."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1187/files/386006313a0b78c614bd1ac522ac121e093df58d#r75811952"}}}</script>