<p>In <a href="https://github.com/geany/geany/pull/1187#discussion_r75841924">src/tagmanager/tm_query.c</a>:</p>
<pre style='color:#555'>> +
> +          if (match && q->type >= 0)
> +                  match = tag->type & q->type;
> +
> +          /* Remove tag from the results. tags are unowned so removing is easy */
> +          if (!match)
> +                  g_queue_unlink(&res, node);
> +  }
> +
> +  /* Convert GQueue to GPtrArray for sort, dedup and return */
> +  i = 0;
> +  ret = g_ptr_array_sized_new(g_queue_get_length(&res));
> +  foreach_list(node, res.head)
> +  {
> +          tag = (TMTag *) node->data;
> +          g_ptr_array_insert(ret, i++, tag);
</pre>
<blockquote>
<p><code>g_ptr_array_add()</code> would just traverse the whole array again and again so it's not the best tool for the job either.</p>
</blockquote>

<p>What makes you think that?  <code>GPtrArray</code> maintains a size, so no need for traversal -- which wouldn't even work with NULL items anyway). And <a href="https://git.gnome.org/browse/glib/tree/glib/garray.c#n1375"><code>g_ptr_array_add()</code> is actually basically implemented as <code>array->pdata[array->len++] = data;</code></a>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1187/files/386006313a0b78c614bd1ac522ac121e093df58d#r75841924">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-EiqeKb4SBYZ6cIYeLT1MCyQdRgks5qis8vgaJpZM4JqVBL">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJzeYLAuKcaz5lUSiKIBCZa3iREiRks5qis8vgaJpZM4JqVBL.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1187/files/386006313a0b78c614bd1ac522ac121e093df58d#r75841924"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #1187: \u003e `g_ptr_array_add()` would just traverse the whole array again and again so it's not the best tool for the job either.\r\n\r\nWhat makes you think that?  `GPtrArray` maintains a size, so no need for traversal -- which wouldn't even work with NULL items anyway). And [`g_ptr_array_add()` is actually basically implemented as `array-\u003epdata[array-\u003elen++] = data;`](https://git.gnome.org/browse/glib/tree/glib/garray.c#n1375)."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1187/files/386006313a0b78c614bd1ac522ac121e093df58d#r75841924"}}}</script>