<blockquote>
<p>I'd definitively not include any custom background image implementation. For VTE versions that support it natively, and we already have UI prefs for, it seems OK to leave it, but for newer VTEs it seems better to just guard it out.</p>
</blockquote>

<p>IMO it would be worth dropping completely everywhere to reduce the amount of ifdef checks. There will be half of them if this gets removed and this mis-feature isn't worth cluttering the code.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1181#issuecomment-241376886">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-7nF7jmMAo5IH6_yFx6iBNVHKK8ks5qiX2ggaJpZM4Jog38">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ9k8yesqXOxxQsp_z4as3q_JvNYCks5qiX2ggaJpZM4Jog38.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1181#issuecomment-241376886"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee in #1181: \u003e I'd definitively not include any custom background image implementation. For VTE versions that support it natively, and we already have UI prefs for, it seems OK to leave it, but for newer VTEs it seems better to just guard it out.\r\n\r\nIMO it would be worth dropping completely everywhere to reduce the amount of ifdef checks. There will be half of them if this gets removed and this mis-feature isn't worth cluttering the code.\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1181#issuecomment-241376886"}}}</script>