<p>Come to think of it, there's no point touching <code>document_rename_file()</code> because it's not useful being used alone, and it shouldn't be used alone since you would need to have everyone that listens to "document-save" to be updated.  It probably even needs to be dropped from the API.</p>

<p>We better just create another function named <code>document_rename_file_and_save()</code> (i.e. <code>gboolean document_rename_file_and_save(GeanyDocument *doc, const gchar *new_filename);</code>) for anyone that would want to use it.  An example for this usage is an in-place renaming of a document in Documents tab.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1180#issuecomment-240956541">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ850bwQz8Q9HVoGiwtlLrEctcm3uks5qhWXhgaJpZM4JnQzb">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ2OJfc8hP0ox3amm9pR4Os5ZYRZMks5qhWXhgaJpZM4JnQzb.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1180#issuecomment-240956541"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@konsolebox in #1180: Come to think of it, there's no point touching `document_rename_file()` because it's not useful being used alone, and it shouldn't be used alone since you would need to have everyone that listens to \"document-save\" to be updated.  It probably even needs to be dropped from the API.\r\n\r\nWe better just create another function named `document_rename_file_and_save()` (i.e. `gboolean document_rename_file_and_save(GeanyDocument *doc, const gchar *new_filename);`) for anyone that would want to use it.  An example for this usage is an in-place renaming of a document in Documents tab."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1180#issuecomment-240956541"}}}</script>