<p>In <a href="https://github.com/geany/geany/pull/1160#discussion_r73956033">ctags/main/routines.c</a>:</p>
<pre style='color:#555'>> +# endif
> +#endif
> +
> +#ifdef HAVE_DIRECT_H
> +# include <direct.h>  /* to _getcwd */
> +#endif
> +#ifdef HAVE_DIR_H
> +# include <dir.h>  /* to declare findfirst() and findnext() */
> +#endif
> +#ifdef HAVE_IO_H
> +# include <io.h>  /* to declare open() */
> +#endif
> +#include "debug.h"
> +#include "routines.h"
> +#ifdef HAVE_ICONV
> +# include "mbcs.h"
</pre>
<p><a href="https://github.com/techee" class="user-mention">@techee</a> opinion on this?  if a user has <code>-DHAVE_ICONV</code> in his <code>C[PP]FLAGS</code>, this will break to his face, even if iconv is actually correctly present.  Sure there is no reason for such a flag to appear, but well.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1160/files/d440a81166e62d41e2b06d555b471db5fdd8d80d..ea72ecc00fc22f24eced3ffce7c7db67d5f02271#r73956033">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJxHRW4ZJqKQfOigXOSthVHPHOADWks5qd5wZgaJpZM4JbITK">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ5cNjTxbFkkvY1Ku4omYYVsBL1nbks5qd5wZgaJpZM4JbITK.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1160/files/d440a81166e62d41e2b06d555b471db5fdd8d80d..ea72ecc00fc22f24eced3ffce7c7db67d5f02271#r73956033"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/modules/aws/aws-bg.jpg","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #1160: @techee opinion on this?  if a user has `-DHAVE_ICONV` in his `C[PP]FLAGS`, this will break to his face, even if iconv is actually correctly present.  Sure there is no reason for such a flag to appear, but well."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1160/files/d440a81166e62d41e2b06d555b471db5fdd8d80d..ea72ecc00fc22f24eced3ffce7c7db67d5f02271#r73956033"}}}</script>