<blockquote>
<p><a href="https://github.com/elextr" class="user-mention">@elextr</a> <a href="https://github.com/techee" class="user-mention">@techee</a> see, <a href="https://github.com/geany/geany/commit/6bc579798716dbe94a171a016f9989c92c4b67e2" class="commit-link"><tt>6bc5797</tt></a> was quicker to review than some previous patches 'cause git show -b <a href="https://github.com/geany/geany/commit/6bc579798716dbe94a171a016f9989c92c4b67e2" class="commit-link"><tt>6bc5797</tt></a> was very straightforward :) (about 62 lines changes (vim settings), instead of about 7446)</p>
</blockquote>

<p>I could have smuggled in some evil indents which you don't see this way :-P. In fact there are some indent diffs compared to uctags - Geany always replaces tabs with spaces but it replaces spaces with tabs only at the beginning of a line:</p>

<p><a href="https://github.com/geany/geany/blob/master/src/editor.c#L4484">https://github.com/geany/geany/blob/master/src/editor.c#L4484</a> (based on the comment in the corresponding commit it's probably OK).</p>

<p>This means that e.g. between</p>

<pre><code>some_code();       /* some comment */
</code></pre>

<p>the whitespace used is incorrect. But the number of these is much smaller and these can get fixed on the way.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1160#issuecomment-237558212">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJwzyutBkzR3cgy0GpQoTAefesB1Vks5qce3cgaJpZM4JbITK">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ-4SSVYXUv-nm4Gj2zY5roDep2Ziks5qce3cgaJpZM4JbITK.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1160#issuecomment-237558212"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/modules/aws/aws-bg.jpg","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee in #1160: \u003e @elextr @techee see, 6bc5797 was quicker to review than some previous patches 'cause git show -b 6bc579798716dbe94a171a016f9989c92c4b67e2 was very straightforward :) (about 62 lines changes (vim settings), instead of about 7446)\r\n\r\nI could have smuggled in some evil indents which you don't see this way :-P. In fact there are some indent diffs compared to uctags - Geany always replaces tabs with spaces but it replaces spaces with tabs only at the beginning of a line:\r\n\r\nhttps://github.com/geany/geany/blob/master/src/editor.c#L4484 (based on the comment in the corresponding commit it's probably OK).\r\n\r\nThis means that e.g. between\r\n\r\n```\r\nsome_code();       /* some comment */\r\n```\r\n\r\nthe whitespace used is incorrect. But the number of these is much smaller and these can get fixed on the way."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1160#issuecomment-237558212"}}}</script>