<p>In <a href="https://github.com/geany/geany/pull/1140#discussion_r70873351">src/document.c</a>:</p>
<pre style='color:#555'>> @@ -1656,6 +1655,12 @@ gboolean document_reload_prompt(GeanyDocument *doc, const gchar *forced_enc)
>    g_free(base_name);
>    return result;
>  }
> +/* also used for reloading when forced_enc is NULL */
> +gboolean document_rename_prompt(GeanyDocument *doc) {
> +  document_show_tab(doc);
> +  dialogs_show_save_as();
> +  return FALSE;
</pre>
<p>why return something if it's always <code>FALSE</code>?  if anything, it should be <code>return dialogs_show_save_as();</code></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1140/files/88f6ad8bebb4a6ef583d1e061ae2faa6d5dd93de#r70873351">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/ABDrJxUfBPokVD_XlDf8QZojt-qJu-FBks5qVpXlgaJpZM4JMx7I">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ8NzN0-mrcUce88gE6zGNl6RbVSlks5qVpXlgaJpZM4JMx7I.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1140/files/88f6ad8bebb4a6ef583d1e061ae2faa6d5dd93de#r70873351"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>