<blockquote>
<p>I don't dislike the cast enough to pay the performance penalty.</p>
</blockquote>

<p>What was the speedup with the cast when you profiled it? :) Cast is evil, especially casting away const-ness. It's entirely possible that pulling a handful of free links of the allocators free list is less costly than the lost optimizations after the compiler throws up its hands when seeing a dangerous cast.</p>

<p>That said, I don't really care, I just doubt that copying a dozen strings once at startup should be considered a performance hit and optimized at the cost of code clarity/quality (notice <a href="https://github.com/elextr" class="user-mention">@elextr</a> asked about it first thing, since it's weird).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1126#issuecomment-231354089">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/ABDrJw9Hc7dl977gt_ZRHRVPH9zFFk3cks5qTksQgaJpZM4JHPP7">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ10YQwc8VHLgYY9-0NSsE5CLZYEeks5qTksQgaJpZM4JHPP7.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1126#issuecomment-231354089"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>