<blockquote>
<p>Ah nice, didn't spot this. Even better yet</p>
</blockquote>

<p>Surely duplicating a handful of strings once isn't going to hurt :)</p>

<blockquote>
<p>But yeah, the cast could be done the other way around in the g_free() call instead of the assignation.</p>
</blockquote>

<p>Could also remove the cast entirely if it used the same ownership semantic for all key groups. Trades a teeny bit of performance for a small code perfume :)</p>

<p>Otherwise it looks OK, assuming no plugins do weird things like identity (pointer) compares with the keygroup names assuming they're going to be the ones they passed in.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1126#issuecomment-231257547">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/ABDrJ6RpUv2cfABPAqBsWcuFsEN9EOuNks5qTa9dgaJpZM4JHPP7">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ3CIUq_MyjHmbM0bBHwN-ZdF9NmCks5qTa9dgaJpZM4JHPP7.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1126#issuecomment-231257547"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>