<p>In <a href="https://github.com/geany/geany/pull/1095#discussion_r68813257">src/spawn.c</a>:</p>
<pre style='color:#555'>> @@ -568,11 +571,52 @@ static gboolean spawn_async_with_pipes(const gchar *working_directory, const gch
> envp++;
> }
>
> - failure = spawn_create_process_with_pipes(command->str, working_directory,
> + // convert working directory into locale encoding
> + if (g_utf8_validate(working_directory, -1, NULL))
> + {
> + locale_working_directory = g_locale_from_utf8(working_directory, -1, NULL, NULL, &gerror);
> + if (gerror) {
> + /* TODO use the code below post-1.28 as it introduces a new string
> + gchar *msg = g_strdup_printf(
> + _("Failed to convert working directory into locale encoding: %s"), gerror->message);
> + g_set_error_literal(error, gerror->domain, gerror->code, msg);
</pre>
<p>that's overly complex, cuold use the non-literal verison of <code>g_set_error()</code></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1095/files/a95f174fe1ab0707c8fc092fceb9294cb92123b3#r68813257">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/ABDrJ4D-cpYdjsRfm1wI-MSC4bjxZeE4ks5qQWYUgaJpZM4I_lTo">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJzSRJw8L7GMuO1z8hvx0l4GaRBLHks5qQWYUgaJpZM4I_lTo.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/geany/geany/pull/1095/files/a95f174fe1ab0707c8fc092fceb9294cb92123b3#r68813257"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>