<p>The brackets are apparently wrong - the check that should happen is</p>

<p>strcmp(text, "2147483648") < 0</p>

<p>but instead the whole expression</p>

<p>(s - text == 10 && strcmp(text, "2147483648"))</p>

<p>is compared if it's less than zero.</p>

<p>Noticed by LLVM:</p>

<p>utils.c:654:50: warning: comparison of constant 0 with boolean expression is always false<br>
      <a href="s%20-%20text%20==%2010%20&&%20strcmp(text," title="2147483648">-Wtautological-constant-out-of-range-compare</a>) < 0) ? text : NULL;<br>
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/geany/geany-plugins/pull/419'>https://github.com/geany/geany-plugins/pull/419</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>scope: Fix validate_number()</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany-plugins/pull/419/files#diff-0">scope/src/utils.c</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/geany/geany-plugins/pull/419.patch'>https://github.com/geany/geany-plugins/pull/419.patch</a></li>
  <li><a href='https://github.com/geany/geany-plugins/pull/419.diff'>https://github.com/geany/geany-plugins/pull/419.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/geany/geany-plugins/pull/419">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJwl9vQYdbBE0AfS9VOGMpYweoS_bks5pySUwgaJpZM4H6tQq.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/419"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>