<p>In <a href="https://github.com/geany/geany/pull/697#discussion_r42182513">src/plugins.c</a>:</p>
<pre style='color:#555'>> @@ -2000,7 +2000,7 @@ gboolean geany_plugin_register_proxy(GeanyPlugin *plugin, const gchar **extensio
>    foreach_list(node, active_proxies.head)
>    {
>            proxy = node->data;
> -          g_return_if_fail(p != proxy->plugin);
> +          g_return_val_if_fail(p != proxy->plugin, FALSE);
</pre>
<p><a href="https://github.com/kugel-" class="user-mention">@kugel-</a> based on the comment above the loop, why does this need to print an error if the plugin is already registered?</p>

<p>The <code>g_return_*</code> functions are only meant for programming errors, see <a href="https://developer.gnome.org/glib/stable/glib-Warnings-and-Assertions.html#glib-Warnings-and-Assertions.description">here</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/geany/geany/pull/697/files#r42182513">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ5TFw9gwPDcqBvNo0xfQN9lHQSUoks5o8BDzgaJpZM4GPtjS.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/697/files#r42182513"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>