[Github-comments] [geany/geany] Add human-readable representation of tags to unit test results (PR #3051)

Enrico Tröger notifications at github.com
Sun May 22 13:38:06 UTC 2022


@eht16 commented on this pull request.



> +
+
+inp = sys.stdin.buffer.read()
+
+tag = {}
+pos = 0
+line_start_pos = 0
+line_start = True
+first_line = True
+while pos < len(inp):
+	part, kind, pos = get_next_part(inp, pos, line_start)
+	value = decode_kind(kind, part)
+	tag[kind] = value
+	line_start = False
+	if inp[pos] == ord('\n'):
+		if not first_line:

Instead of blindly skipping the first line (which is supposed to be like "# format=tagmanager"), we could more flexible ignore all comments at all (i.e. every line starting with '#').

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3051#pullrequestreview-980962064
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3051/review/980962064 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220522/f0dca682/attachment-0001.htm>


More information about the Github-comments mailing list