[Github-comments] [geany/geany] Don't use temporary file when creating tag files without running preprocessor (PR #3204)

[elextr]

@elextr commented on this pull request.



> @@ -453,19 +419,19 @@ static GList *lookup_includes(const gchar **includes, gint includes_count)
 #ifdef HAVE_GLOB_H
 	globbuf.gl_offs = 0;
 
-	if (includes[0][0] == '"')	/* leading \" char for glob matching */
+	if (sources[0][0] == '"')	/* leading \" char for glob matching */

I know its not something you changed (except the variable name) but where did this `"` come from?  Its not mentioned in the manual as being required for globbing, nor in the parameter description of `sources`?

Also its only tested on `sources[0]` but then assumed on all sources below.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3204#pullrequestreview-973108384
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3204/review/973108384 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220514/807d9a63/attachment.htm>