[Github-comments] [geany/geany] Enable local variables for C/C++ and improve autocompletion (PR #3185)

Thomas Martitz notifications at github.com
Tue May 10 05:32:55 UTC 2022


> I am also still waiting on replies to my comments on your own PRs https://github.com/geany/geany/pull/3178 and https://github.com/geany/geany/pull/1813, clearly other peoples contributions don't matter to you.

This PR is currently taking all my Geany-time, it's simple as that. Besides, I already made the suggested code changes to #3178, I only failed to notify you with an explicit comment (fixed that now).

> @kugel- so your approach is to smash and run.

Please don't make rude accusation like that. I do not run, I'm here. I'm just trying to get this PR into a shape that I can review with confidence. It's in that state now, and I'm accepting the changes (aside from the minor comment request). I'm not going to respond to the other false accusation in your post, lets focus on getting this over the finish line.

> Many observers will have been astonished that I haven't mentioned my favourite topic (documentation) so far

Good call! I like your suggestion.  Normally I would say documentation ought to be part of the PR that implements it, but given that a) this PR is already heated such that I would rather get over it (by merging) and b) there is more to come that affects the documentation, I may suggest to deal with that at a later point.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3185#issuecomment-1121949738
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3185/c1121949738 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220509/2df19bda/attachment-0001.htm>


More information about the Github-comments mailing list