[Github-comments] [geany/geany] Support gtk-mac-integration by meson build (PR #3194)

Thomas Martitz notifications at github.com
Sat May 7 20:37:24 UTC 2022


@kugel- commented on this pull request.



> @@ -6,3 +6,4 @@ option('api-docs', type : 'feature', description : 'enable to generate API docum
 option('gtkdoc', type : 'boolean', description : 'enable to generate gtk-doc compatible headers for the API')
 option('python-command', type: 'string', description: 'the default Python command')
 option('socket', type: 'boolean', description: 'enable if you want to detect a running instance')
+option('mac-integration', type: 'boolean', value: 'false', description: 'enable for improved macOS integration using the gtk-mac-integration library')

Probably in-line with autotools but I wonder why this is off by default? Couldn't this default to on and maybe dynamically detect presence of the dependency (or simply require it unless mac-integration is explicitly disabled)?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3194#pullrequestreview-965362127
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3194/review/965362127 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220507/6286fe36/attachment.htm>


More information about the Github-comments mailing list