[Github-comments] [geany/geany] Use the upstream TCL parser (PR #3157)

Thomas Martitz notifications at github.com
Tue May 3 14:28:16 UTC 2022


@kugel- approved this pull request.

I didn't dive into the parser, rest looks good to me.

>  
-public method method1
-protected method method2
-private method method3

Not sure if it matters but the new tests don't include public/private methods, TclOO supports these according to https://wiki.tcl-lang.org/page/TclOO+Tutorial, but I don't know if it ctags handles it at all?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3157#pullrequestreview-960459183
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3157/review/960459183 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220503/ad88c24e/attachment.htm>


More information about the Github-comments mailing list