[Github-comments] [geany/geany] Enable local variables for C/C++ and improve autocompletion (PR #3185)

[elextr]

@kugel-  I don't see the searching and sorting and header parts as something separate from enabling local variables, they are an integral part of presenting the locals to the user in a usable manner.   

You complained about separation of the conversation on #3175 but it does not appear you understood it.  Otherwise you would have understood that without the filtering and the ordering parts of the PR unrelated globals from the C/C++ global tags files overwhelm the locals in the autocomplete list and make them unusable.

And without the work for selecting the most likely base symbol for scope autocomplete it is also less useful since it will be more likely to present completions for the wrong variable.

Locals are inherently scoped, and inner scopes hide outer scopes.  So "enabling locals" inherently involves handling scopes, and those rules are inherently language specific, see the examples in #3175.  Geany does not have exact scope detection, especially with include files, so the sorting and filtering, including (for C/C++) prioritising header file symbols over globals provides a heuristic for presenting the most likely candidates at the top of the autocomplete list, and choosing the most likely base for scope autocomplete so making them usable

Splitting the PR now means more work, double testing, the initial PR presenting a bad experience, and the risk of introducing bugs in the split.

For all the above reasons I do not support splitting this PR.

I did react negatively to your blocking and seeming to demand it be split after seeming to accept the PR as I pointed out above, and I apologise for that.  Perhaps you didn't mean to seem to accept it, and you didn't mean to be demanding without reason.  English is imprecise and usages vary around the world, here "please do x" means "I would like you to do x if its reasonable", whereas "do x please" means "I demand you do x and am saying please just to be polite", but I am not sure its the same in other English speaking countries, let alone when English is not a first language.
 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3185#issuecomment-1114354243
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3185/c1114354243 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220501/9df1f3c3/attachment.htm>