[Github-comments] [geany/geany] Enable local variables for C/C++ and improve autocompletion (PR #3185)

[Thomas Martitz]

The "look for files that could be headers corresponding to this C file" is clearly a new feature that has *nothing* to do with local tags. I did not realize that this feature was added to the previous PR until starting an in-depth review on this PR. I also never said that I don't like it or do not want it in Geany, I just want to discuss and review it separately because I have some doubts about the implemented assumptions and I don't want the "local tags" effort to be blocked by that. It's also a big chunk of the overall diff and I like to review smaller diffs.

I followed your discussion on the other PR but I simply didn't have the time for a in-depth review yet. Sorry for being late to the party.

If you're not going to spend time to remove it then I won't spend any more time to review this PR. Clearly you have @elextr already be happy enough to get this over the finish line without my involvement - and that's perfectly fine. There is also nothing in the diff that's fatally wrong so just go ahead.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3185#issuecomment-1114345395
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3185/c1114345395 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220501/33fc21b5/attachment.htm>