[Github-comments] [geany/geany] Enable local variables for C/C++ and improve autocompletion (PR #3185)

[Thomas Martitz]

I can't follow. Yesterday I tried to review the whole thing for the first time. I was striked how large the change has become since my initial, very coarse, look (that wasnt a review) and have found that a lot of unrelated changes (w.r.t. to local tags) were added. GitHub even hides the diff for tm_workspace by default!! Since I also want this feature I'm trying to accept most of them in one PR although I don't feel truly confident. But the header feature a bit too much for my taste and should be dealt with separately.

>From what I can see its a single commit that has to be backed out, provably not much of a hassle.

For the future I wish that PRs stay focused on what they were created for and don't accumulate  many unrelated changes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3185#issuecomment-1114213766
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3185/c1114213766 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220501/59a3e8b6/attachment.htm>